meineerde/redmine
1
0
Fork 0
mirror of https://github.com/meineerde/redmine.git synced 2026-02-03 23:53:23 +00:00
Code Issues Releases Wiki Activity

Use assert_selector which automatically waits until the HTML condition is met (#39109).

Browse Source 
Patch by Takashi Kato.

git-svn-id: https://svn.redmine.org/redmine/trunk@22372 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Marius Balteanu 2023-10-24 19:06:43 +00:00
parent b141aed19f
commit 7ba9cb1da6
2 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
test/system/issues_test.rb
View File

@ -443,8 +443,8 @@ class IssuesSystemTest < ApplicationSystemTestCase
# wait for ajax response
assert page.has_select?('issue_project_id', selected: 'OnlineStore')
assert_selector 'input[type=submit]', count: 2
submit_buttons = page.all('input[type=submit]')
assert_equal 2, submit_buttons.size
assert_equal 'Move', submit_buttons[0].value
assert_equal 'Move and follow', submit_buttons[1].value
@ -507,8 +507,9 @@ class IssuesSystemTest < ApplicationSystemTestCase
# wait for ajax response
assert page.has_select?('issue_project_id', selected: 'OnlineStore')
assert_selector 'input[type=submit]', count: 2
submit_buttons = page.all('input[type=submit]')
assert_equal 2, submit_buttons.size
assert_equal 'Copy', submit_buttons[0].value
assert_equal 'Copy and follow', submit_buttons[1].value
page.find('#issue_priority_id').select('High')
@ -645,7 +646,7 @@ class IssuesSystemTest < ApplicationSystemTestCase
wait_for_ajax
# assert log time form does not exist anymore for user without required permissions on the new project
assert_not page.has_css?('#log_time')
assert page.has_no_css?('#log_time')
end
def test_update_issue_form_should_include_add_notes_form_only_for_users_with_permission
@ -665,6 +666,6 @@ class IssuesSystemTest < ApplicationSystemTestCase
wait_for_ajax
# assert add notes form does not exist anymore for user without required permissions on the new project
assert_not page.has_css?('#add_notes')
assert page.has_no_css?('#add_notes')
end
end

4
test/system/timelog_test.rb
View File

@ -43,7 +43,7 @@ class TimelogTest < ApplicationSystemTestCase
end
within 'select#time_entry_activity_id' do
assert has_content?('Development')
assert !has_content?('Design')
assert has_no_content?('Design')
end
end
@ -69,7 +69,7 @@ class TimelogTest < ApplicationSystemTestCase
fill_in 'Hours', :with => '7'
page.first(:button, 'Submit').click
assert_equal "/projects/ecookbook/time_entries", current_path
assert_current_path "/projects/ecookbook/time_entries"
entries = TimeEntry.where(:id => [1,2,3]).to_a
assert entries.all? {|entry| entry.hours == 7.0}
end