meineerde/redmine
1
0
Fork 0
mirror of https://github.com/meineerde/redmine.git synced 2025-12-19 15:01:14 +00:00
Code Issues Releases Wiki Activity

Raises wiki edits comments limit to 1024 (#19886).

Browse Source 
git-svn-id: http://svn.redmine.org/redmine/trunk@14622 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Jean-Philippe Lang 2015-09-21 21:13:06 +00:00
parent 5882629e26
commit 7b12145ed9
4 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/models/wiki_content.rb
View File

@ -22,7 +22,7 @@ class WikiContent < ActiveRecord::Base
belongs_to :page, :class_name => 'WikiPage' belongs_to :page, :class_name => 'WikiPage'
belongs_to :author, :class_name => 'User' belongs_to :author, :class_name => 'User'
validates_presence_of :text validates_presence_of :text
validates_length_of :comments, :maximum => 255, :allow_nil => true validates_length_of :comments, :maximum => 1024, :allow_nil => true
attr_protected :id attr_protected :id
acts_as_versioned acts_as_versioned

2
app/views/wiki/edit.html.erb
View File

@ -29,7 +29,7 @@
<% end %> <% end %>
<% end %> <% end %>
<p><label><%= l(:field_comments) %></label><%= f.text_field :comments, :size => 120 %></p> <p><label><%= l(:field_comments) %></label><%= f.text_field :comments, :size => 120, :maxlength => 1024 %></p>
<p><label><%=l(:label_attachment_plural)%></label><%= render :partial => 'attachments/form' %></p> <p><label><%=l(:label_attachment_plural)%></label><%= render :partial => 'attachments/form' %></p>
</div> </div>

11
db/migrate/20150921210243_change_wiki_contents_comments_limit_to_1024.rb Normal file
View File

@ -0,0 +1,11 @@
class ChangeWikiContentsCommentsLimitTo1024 < ActiveRecord::Migration
def self.up
change_column :wiki_content_versions, :comments, :string, :limit => 1024, :default => ''
change_column :wiki_contents, :comments, :string, :limit => 1024, :default => ''
end
def self.down
change_column :wiki_content_versions, :comments, :string, :limit => 255, :default => ''
change_column :wiki_contents, :comments, :string, :limit => 255, :default => ''
end
end

2
test/functional/wiki_controller_test.rb
View File

@ -319,7 +319,7 @@ class WikiControllerTest < ActionController::TestCase
put :update, :project_id => 1, put :update, :project_id => 1,
:id => 'Another_page', :id => 'Another_page',
:content => { :content => {
:comments => 'a' * 300, # failure here, comment is too long :comments => 'a' * 1300, # failure here, comment is too long
:text => 'edited' :text => 'edited'
}, },
:wiki_page => { :wiki_page => {