1
0
mirror of https://github.com/meineerde/redmine.git synced 2026-03-25 02:09:57 +00:00

cleanup: rubocop: fix Layout/IndentFirstHashElement in test/functional/issue_categories_controller_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19274 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Toshi MARUYAMA 2019-11-24 16:45:33 +00:00
parent 504cb8e147
commit 78c7603cdc

View File

@ -30,20 +30,20 @@ class IssueCategoriesControllerTest < Redmine::ControllerTest
def test_new def test_new
@request.session[:user_id] = 2 # manager @request.session[:user_id] = 2 # manager
get :new, :params => { get(:new, :params => {:project_id => '1'})
:project_id => '1'
}
assert_response :success assert_response :success
assert_select 'input[name=?]', 'issue_category[name]' assert_select 'input[name=?]', 'issue_category[name]'
end end
def test_new_from_issue_form def test_new_from_issue_form
@request.session[:user_id] = 2 # manager @request.session[:user_id] = 2 # manager
get :new, :params => { get(
:new,
:params => {
:project_id => '1' :project_id => '1'
}, },
:xhr => true :xhr => true
)
assert_response :success assert_response :success
assert_equal 'text/javascript', response.content_type assert_equal 'text/javascript', response.content_type
end end
@ -51,12 +51,15 @@ class IssueCategoriesControllerTest < Redmine::ControllerTest
def test_create def test_create
@request.session[:user_id] = 2 # manager @request.session[:user_id] = 2 # manager
assert_difference 'IssueCategory.count' do assert_difference 'IssueCategory.count' do
post :create, :params => { post(
:create,
:params => {
:project_id => '1', :project_id => '1',
:issue_category => { :issue_category => {
:name => 'New category' :name => 'New category'
} }
} }
)
end end
assert_redirected_to '/projects/ecookbook/settings/categories' assert_redirected_to '/projects/ecookbook/settings/categories'
category = IssueCategory.find_by_name('New category') category = IssueCategory.find_by_name('New category')
@ -66,12 +69,15 @@ class IssueCategoriesControllerTest < Redmine::ControllerTest
def test_create_failure def test_create_failure
@request.session[:user_id] = 2 @request.session[:user_id] = 2
post :create, :params => { post(
:create,
:params => {
:project_id => '1', :project_id => '1',
:issue_category => { :issue_category => {
:name => '' :name => ''
} }
} }
)
assert_response :success assert_response :success
assert_select_error /Name cannot be blank/i assert_select_error /Name cannot be blank/i
end end
@ -79,13 +85,16 @@ class IssueCategoriesControllerTest < Redmine::ControllerTest
def test_create_from_issue_form def test_create_from_issue_form
@request.session[:user_id] = 2 # manager @request.session[:user_id] = 2 # manager
assert_difference 'IssueCategory.count' do assert_difference 'IssueCategory.count' do
post :create, :params => { post(
:create,
:params => {
:project_id => '1', :project_id => '1',
:issue_category => { :issue_category => {
:name => 'New category' :name => 'New category'
} }
}, },
:xhr => true :xhr => true
)
end end
category = IssueCategory.order('id DESC').first category = IssueCategory.order('id DESC').first
assert_equal 'New category', category.name assert_equal 'New category', category.name
@ -97,13 +106,16 @@ class IssueCategoriesControllerTest < Redmine::ControllerTest
def test_create_from_issue_form_with_failure def test_create_from_issue_form_with_failure
@request.session[:user_id] = 2 # manager @request.session[:user_id] = 2 # manager
assert_no_difference 'IssueCategory.count' do assert_no_difference 'IssueCategory.count' do
post :create, :params => { post(
:create,
:params => {
:project_id => '1', :project_id => '1',
:issue_category => { :issue_category => {
:name => '' :name => ''
} }
}, },
:xhr => true :xhr => true
)
end end
assert_response :success assert_response :success
@ -113,59 +125,62 @@ class IssueCategoriesControllerTest < Redmine::ControllerTest
def test_edit def test_edit
@request.session[:user_id] = 2 @request.session[:user_id] = 2
get :edit, :params => { get(:edit, :params => {:id => 2})
:id => 2
}
assert_response :success assert_response :success
assert_select 'input[name=?][value=?]', 'issue_category[name]', 'Recipes' assert_select 'input[name=?][value=?]', 'issue_category[name]', 'Recipes'
end end
def test_update def test_update
assert_no_difference 'IssueCategory.count' do assert_no_difference 'IssueCategory.count' do
put :update, :params => { put(
:update,
:params => {
:id => 2, :id => 2,
:issue_category => { :issue_category => {
:name => 'Testing' :name => 'Testing'
} }
} }
)
end end
assert_redirected_to '/projects/ecookbook/settings/categories' assert_redirected_to '/projects/ecookbook/settings/categories'
assert_equal 'Testing', IssueCategory.find(2).name assert_equal 'Testing', IssueCategory.find(2).name
end end
def test_update_failure def test_update_failure
put :update, :params => { put(
:update,
:params => {
:id => 2, :id => 2,
:issue_category => { :issue_category => {
:name => '' :name => ''
} }
} }
)
assert_response :success assert_response :success
assert_select_error /Name cannot be blank/i assert_select_error /Name cannot be blank/i
end end
def test_update_not_found def test_update_not_found
put :update, :params => { put(
:update,
:params => {
:id => 97, :id => 97,
:issue_category => { :issue_category => {
:name => 'Testing' :name => 'Testing'
} }
} }
)
assert_response 404 assert_response 404
end end
def test_destroy_category_not_in_use def test_destroy_category_not_in_use
delete :destroy, :params => { delete(:destroy, :params => {:id => 2})
:id => 2
}
assert_redirected_to '/projects/ecookbook/settings/categories' assert_redirected_to '/projects/ecookbook/settings/categories'
assert_nil IssueCategory.find_by_id(2) assert_nil IssueCategory.find_by_id(2)
end end
def test_destroy_category_in_use def test_destroy_category_in_use
delete :destroy, :params => { delete(:destroy, :params => {:id => 1})
:id => 1
}
assert_response :success assert_response :success
assert_not_nil IssueCategory.find_by_id(1) assert_not_nil IssueCategory.find_by_id(1)
assert_select 'select[name=?]', 'reassign_to_id' assert_select 'select[name=?]', 'reassign_to_id'
@ -173,11 +188,14 @@ class IssueCategoriesControllerTest < Redmine::ControllerTest
def test_destroy_category_in_use_with_reassignment def test_destroy_category_in_use_with_reassignment
issue = Issue.where(:category_id => 1).first issue = Issue.where(:category_id => 1).first
delete :destroy, :params => { delete(
:destroy,
:params => {
:id => 1, :id => 1,
:todo => 'reassign', :todo => 'reassign',
:reassign_to_id => 2 :reassign_to_id => 2
} }
)
assert_redirected_to '/projects/ecookbook/settings/categories' assert_redirected_to '/projects/ecookbook/settings/categories'
assert_nil IssueCategory.find_by_id(1) assert_nil IssueCategory.find_by_id(1)
# check that the issue was reassign # check that the issue was reassign
@ -186,10 +204,13 @@ class IssueCategoriesControllerTest < Redmine::ControllerTest
def test_destroy_category_in_use_without_reassignment def test_destroy_category_in_use_without_reassignment
issue = Issue.where(:category_id => 1).first issue = Issue.where(:category_id => 1).first
delete :destroy, :params => { delete(
:destroy,
:params => {
:id => 1, :id => 1,
:todo => 'nullify' :todo => 'nullify'
} }
)
assert_redirected_to '/projects/ecookbook/settings/categories' assert_redirected_to '/projects/ecookbook/settings/categories'
assert_nil IssueCategory.find_by_id(1) assert_nil IssueCategory.find_by_id(1)
# check that the issue category was nullified # check that the issue category was nullified