meineerde/redmine
1
0
Fork 0
mirror of https://github.com/meineerde/redmine.git synced 2025-12-20 07:21:12 +00:00
Code Issues Releases Wiki Activity

code cleanup: rubocop: fix Lint/IneffectiveAccessModifier in app/models/issue.rb

Browse Source 
git-svn-id: http://svn.redmine.org/redmine/trunk@18780 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Toshi MARUYAMA 2019-10-19 13:33:43 +00:00
parent fd7675adf2
commit 75d3e4037b
2 changed files with 18 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.rubocop_todo.yml
View File

@ -391,7 +391,6 @@ Lint/HandleExceptions:
Lint/IneffectiveAccessModifier:
Exclude:
- 'app/models/attachment.rb'
- 'app/models/issue.rb'
- 'app/models/mail_handler.rb'
Lint/InterpolationCheck:

5
app/models/issue.rb
View File

@ -1724,9 +1724,11 @@ class Issue < ActiveRecord::Base
end
end
# Singleton class method is public
class << self
# Update issues so their versions are not pointing to a
# fixed_version that is not shared with the issue's project
def self.update_versions(conditions=nil)
def update_versions(conditions=nil)
# Only need to update issues with a fixed_version from
# a different project and that is not systemwide shared
Issue.joins(:project, :fixed_version).
@ -1742,6 +1744,7 @@ class Issue < ActiveRecord::Base
end
end
end
end
def delete_selected_attachments
if deleted_attachment_ids.present?