meineerde/redmine
1
0
Fork 0
mirror of https://github.com/meineerde/redmine.git synced 2026-02-06 09:03:25 +00:00
Code Issues Releases Wiki Activity

Fixed undefined method `compact!' error when additional_user_ids is empty (#19253).

Browse Source 
git-svn-id: http://svn.redmine.org/redmine/trunk@14053 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Jean-Philippe Lang 2015-03-07 16:21:59 +00:00
parent 0965aafd51
commit 730bba8130
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/controllers/repositories_controller.rb
View File

@ -92,7 +92,7 @@ class RepositoriesController < ApplicationController
def committers
@committers = @repository.committers
@users = @project.users
@users = @project.users.to_a
additional_user_ids = @committers.collect(&:last).collect(&:to_i) - @users.collect(&:id)
@users += User.where(:id => additional_user_ids).to_a unless additional_user_ids.empty?
@users.compact!

9
test/functional/repositories_controller_test.rb
View File

@ -279,6 +279,15 @@ class RepositoriesControllerTest < ActionController::TestCase
assert_select 'input[value=foo] + select option[selected=selected]', 0 # no option selected
end
def test_get_committers_without_changesets
Changeset.delete_all
@request.session[:user_id] = 2
get :committers, :id => 10
assert_response :success
assert_template 'committers'
end
def test_post_committers
@request.session[:user_id] = 2
# add a commit with an unknown user