From 72a163d8b30978f23059ba2a2083675a38bd5680 Mon Sep 17 00:00:00 2001 From: Go MAEDA Date: Sun, 17 Mar 2019 06:10:53 +0000 Subject: [PATCH] Support frozen_string_literal in lib/redmine/export/*.rb (#26561). MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Contributed by Pavel Rosický. git-svn-id: http://svn.redmine.org/redmine/trunk@17985 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- lib/redmine/export/csv.rb | 13 +++++++------ lib/redmine/export/pdf/issues_pdf_helper.rb | 4 ++-- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/lib/redmine/export/csv.rb b/lib/redmine/export/csv.rb index d85b7925a..9df6cf29c 100644 --- a/lib/redmine/export/csv.rb +++ b/lib/redmine/export/csv.rb @@ -1,4 +1,4 @@ -# frozen_string_literal: false +# frozen_string_literal: true # Redmine - project management software # Copyright (C) 2006-2017 Jean-Philippe Lang @@ -35,11 +35,12 @@ module Redmine col_sep = l(:general_csv_separator) encoding = Encoding.find(options[:encoding]) rescue Encoding.find(l(:general_csv_encoding)) - str = ''.force_encoding(encoding) - if encoding == Encoding::UTF_8 - # BOM - str = "\xEF\xBB\xBF".force_encoding(encoding) - end + str = + if encoding == Encoding::UTF_8 + +"\xEF\xBB\xBF" # BOM + else + (+'').force_encoding(encoding) + end super(str, :col_sep => col_sep, :encoding => encoding, &block) end diff --git a/lib/redmine/export/pdf/issues_pdf_helper.rb b/lib/redmine/export/pdf/issues_pdf_helper.rb index 6113064c1..14a20d74e 100644 --- a/lib/redmine/export/pdf/issues_pdf_helper.rb +++ b/lib/redmine/export/pdf/issues_pdf_helper.rb @@ -1,4 +1,4 @@ -# frozen_string_literal: false +# frozen_string_literal: true # Redmine - project management software # Copyright (C) 2006-2017 Jean-Philippe Lang @@ -305,7 +305,7 @@ module Redmine if query.grouped? && (group = query.group_by_column.group_value(issue)) != previous_group pdf.SetFontStyle('B',10) - group_label = group.blank? ? 'None' : group.to_s.dup + group_label = group.blank? ? +'None' : group.to_s.dup group_label << " (#{result_count_by_group[group]})" pdf.bookmark group_label, 0, -1 pdf.RDMCell(table_width, row_height * 2, group_label, 'LR', 1, 'L')