meineerde/redmine
1
0
Fork 0
mirror of https://github.com/meineerde/redmine.git synced 2026-01-09 09:01:31 +00:00
Code Issues Releases Wiki Activity

Use MiniTest::Assertions#skip to skip tests in RepositoriesControllerTest when Subversion test repository is not configured (#8875).

Browse Source 
git-svn-id: http://svn.redmine.org/redmine/trunk@20774 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Go MAEDA 2021-03-11 08:05:29 +00:00
parent 880632eb6f
commit 6b13b3cc4d
2 changed files with 34 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

58
test/functional/repositories_controller_test.rb
View File

@ -188,37 +188,39 @@ class RepositoriesControllerTest < Redmine::RepositoryControllerTest
end
end
if repository_configured?('subversion')
def test_show_should_show_diff_button_depending_on_browse_repository_permission
@request.session[:user_id] = 2
role = Role.find(1)
def test_show_should_show_diff_button_depending_on_browse_repository_permission
skip unless repository_configured?('subversion')
role.add_permission! :browse_repository
get(:show, :params => {:id => 1})
@request.session[:user_id] = 2
role = Role.find(1)
role.add_permission! :browse_repository
get(:show, :params => {:id => 1})
assert_response :success
assert_select 'input[value="View differences"]'
role.remove_permission! :browse_repository
get(:show, :params => {:id => 1})
assert_response :success
assert_select 'input[value="View differences"]', :count => 0
end
def test_fetch_changesets
skip unless repository_configured?('subversion')
@request.session[:user_id] = 2
role = Role.find(1)
with_settings :autofetch_changesets => '0' do
role.add_permission! :manage_repository
Repository::Subversion.any_instance.expects(:fetch_changesets).once
post(:fetch_changesets, :params => {:id => 1, :repository_id => 10})
assert_response :success
assert_select 'input[value="View differences"]'
role.remove_permission! :browse_repository
get(:show, :params => {:id => 1})
assert_response :success
assert_select 'input[value="View differences"]', :count => 0
end
def test_fetch_changesets
@request.session[:user_id] = 2
role = Role.find(1)
with_settings :autofetch_changesets => '0' do
role.add_permission! :manage_repository
Repository::Subversion.any_instance.expects(:fetch_changesets).once
post(:fetch_changesets, :params => {:id => 1, :repository_id => 10})
assert_response :success
role.remove_permission! :manage_repository
Repository::Subversion.any_instance.expects(:fetch_changesets).never
post(:fetch_changesets, :params => {:id => 1, :repository_id => 10})
assert_response :forbidden
end
role.remove_permission! :manage_repository
Repository::Subversion.any_instance.expects(:fetch_changesets).never
post(:fetch_changesets, :params => {:id => 1, :repository_id => 10})
assert_response :forbidden
end
end

4
test/test_helper.rb
View File

@ -163,6 +163,10 @@ class ActiveSupport::TestCase
File.directory?(repository_path(vendor))
end
def repository_configured?(vendor)
self.class.repository_configured?(vendor)
end
def self.is_mysql_utf8mb4
return false unless Redmine::Database.mysql?