From 5fffbdc0162c5454c4e2f3f9cb877a83b4de4483 Mon Sep 17 00:00:00 2001 From: Jean-Philippe Lang Date: Sat, 15 Aug 2015 09:19:12 +0000 Subject: [PATCH] CSV importer raises I18n::InvalidLocale exception if current user's language is "(auto)" (#905, #20535). git-svn-id: http://svn.redmine.org/redmine/trunk@14504 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- lib/redmine/i18n.rb | 2 +- test/unit/lib/redmine/i18n_test.rb | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/lib/redmine/i18n.rb b/lib/redmine/i18n.rb index b028e3e30..7fa88230f 100644 --- a/lib/redmine/i18n.rb +++ b/lib/redmine/i18n.rb @@ -60,7 +60,7 @@ module Redmine # Localizes the given args with user's language def lu(user, *args) - lang = user.try(:language) || Setting.default_language + lang = user.try(:language).presence || Setting.default_language ll(lang, *args) end diff --git a/test/unit/lib/redmine/i18n_test.rb b/test/unit/lib/redmine/i18n_test.rb index 0c42ccc03..90e01bf89 100644 --- a/test/unit/lib/redmine/i18n_test.rb +++ b/test/unit/lib/redmine/i18n_test.rb @@ -162,6 +162,15 @@ class Redmine::I18nTest < ActiveSupport::TestCase assert_equal "-1000,20 #{euro_sign}", number_to_currency(-1000.2) end + def test_lu_should_not_error_when_user_language_is_an_empty_string + user = User.new + user.language = '' + + assert_nothing_raised do + lu(user, :label_issue) + end + end + def test_valid_languages assert valid_languages.is_a?(Array) assert valid_languages.first.is_a?(Symbol)