meineerde/redmine
1
0
Fork 0
mirror of https://github.com/meineerde/redmine.git synced 2026-01-31 11:37:14 +00:00
Code Issues Releases Wiki Activity

Keep existing @##@ syntax when triggering an issue from the inline autocomplete (#38852).

Browse Source 
git-svn-id: https://svn.redmine.org/redmine/trunk@22419 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Marius Balteanu 2023-11-11 07:10:51 +00:00
parent 5013c28431
commit 5f028722d5
2 changed files with 22 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
public/javascripts/application.js
View File

@ -1172,7 +1172,12 @@ function inlineAutoComplete(element) {
fillAttr: 'label',
requireLeadingSpace: true,
selectTemplate: function (issue) {
return '#' + issue.original.id;
let leadingHash = "#"
// keep ## syntax which is a valid issue syntax to show issue with title.
if (this.currentMentionTextSnapshot.charAt(0) === "#") {
leadingHash = "##"
}
return leadingHash + issue.original.id;
},
menuItemTemplate: function (issue) {
return sanitizeHTML(issue.original.label);

16
test/system/inline_autocomplete_test.rb
View File

@ -43,6 +43,22 @@ class InlineAutocompleteSystemTest < ApplicationSystemTestCase
assert_equal '#12 ', find('#issue_description').value
end
def test_inline_autocomplete_for_issues_with_double_hash_keep_syntax
log_user('admin', 'admin')
visit 'projects/ecookbook/issues/new'
fill_in 'Description', :with => '##Closed'
within('.tribute-container') do
assert page.has_text? 'Bug #12: Closed issue on a locked version'
assert page.has_text? 'Bug #11: Closed issue on a closed version'
first('li').click
end
assert_equal '##12 ', find('#issue_description').value
end
def test_inline_autocomplete_filters_autocomplete_items
log_user('jsmith', 'jsmith')
visit 'issues/new'