From 5416ed10222c82fbb1167377f0c7cb49e58ef4d7 Mon Sep 17 00:00:00 2001 From: Jean-Philippe Lang Date: Sat, 6 Oct 2018 13:09:38 +0000 Subject: [PATCH] Cleanup: Remove Issue#each_notification and Journal#each_notification (#26791). Patch by Holger Just. git-svn-id: http://svn.redmine.org/redmine/trunk@17584 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- app/models/issue.rb | 15 --------------- app/models/journal.rb | 13 ------------- 2 files changed, 28 deletions(-) diff --git a/app/models/issue.rb b/app/models/issue.rb index aa2c08b33..d38a4f5ea 100644 --- a/app/models/issue.rb +++ b/app/models/issue.rb @@ -1047,21 +1047,6 @@ class Issue < ActiveRecord::Base notified_users.collect(&:mail) end - def each_notification(users, &block) - if users.any? - if custom_field_values.detect {|value| !value.custom_field.visible?} - users_by_custom_field_visibility = users.group_by do |user| - visible_custom_field_values(user).map(&:custom_field_id).sort - end - users_by_custom_field_visibility.values.each do |users| - yield(users) - end - else - yield(users) - end - end - end - def notify? @notify != false end diff --git a/app/models/journal.rb b/app/models/journal.rb index 77823d0c2..cc96967f5 100644 --- a/app/models/journal.rb +++ b/app/models/journal.rb @@ -94,19 +94,6 @@ class Journal < ActiveRecord::Base end end - def each_notification(users, &block) - if users.any? - users_by_details_visibility = users.group_by do |user| - visible_details(user) - end - users_by_details_visibility.each do |visible_details, users| - if notes? || visible_details.any? - yield(users) - end - end - end - end - # Returns the JournalDetail for the given attribute, or nil if the attribute # was not updated def detail_for_attribute(attribute)