From 51fdc31e1c4943895a25eed89dc0e9c3dc4e5a88 Mon Sep 17 00:00:00 2001 From: Go MAEDA Date: Mon, 2 Jul 2018 02:36:22 +0000 Subject: [PATCH] "thumbnail" macro may break filename attribute of the attachment (#29038). Patch by Toru Takahashi. git-svn-id: http://svn.redmine.org/redmine/trunk@17428 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- app/models/attachment.rb | 2 +- test/unit/attachment_test.rb | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/app/models/attachment.rb b/app/models/attachment.rb index 47955c0b1..6795f602e 100644 --- a/app/models/attachment.rb +++ b/app/models/attachment.rb @@ -155,7 +155,7 @@ class Attachment < ActiveRecord::Base end def title - title = filename.to_s + title = filename.dup if description.present? title << " (#{description})" end diff --git a/test/unit/attachment_test.rb b/test/unit/attachment_test.rb index dcad6f23d..2bee67ed2 100644 --- a/test/unit/attachment_test.rb +++ b/test/unit/attachment_test.rb @@ -258,6 +258,7 @@ class AttachmentTest < ActiveSupport::TestCase a = Attachment.new(:filename => "test.png", :description => "Cool image") assert_equal "test.png (Cool image)", a.title + assert_equal "test.png", a.filename end def test_new_attachment_should_be_editable_by_author