1
0
mirror of https://github.com/meineerde/redmine.git synced 2026-02-01 03:57:15 +00:00
Patch by Takenori TAKAKI.

git-svn-id: http://svn.redmine.org/redmine/trunk@17646 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Jean-Philippe Lang 2018-11-28 18:15:56 +00:00
parent bee7f2531b
commit 4770fa5b6a
3 changed files with 39 additions and 0 deletions

View File

@ -37,6 +37,16 @@ class Redmine::ListFieldFormatTest < ActionView::TestCase
assert group.valid?
end
def test_non_existing_value_should_be_invalid
field = GroupCustomField.create!(:name => 'List', :field_format => 'list', :possible_values => ['Foo', 'Bar'])
group = Group.new(:name => 'Group')
group.custom_field_values = {field.id => 'Baz'}
assert_not_include 'Baz', field.possible_custom_value_options(group.custom_value_for(field))
assert_equal false, group.valid?
assert_include "List #{::I18n.t('activerecord.errors.messages.inclusion')}", group.errors.full_messages.first
end
def test_edit_tag_should_have_id_and_name
field = IssueCustomField.new(:field_format => 'list', :possible_values => ['Foo', 'Bar'], :is_required => false)
value = CustomFieldValue.new(:custom_field => field, :customized => Issue.new)

View File

@ -45,6 +45,21 @@ class Redmine::UserFieldFormatTest < ActionView::TestCase
assert issue.valid?
end
def test_non_existing_values_should_be_invalid
field = IssueCustomField.create!(:name => 'Foo', :field_format => 'user', :is_for_all => true, :trackers => Tracker.all)
project = Project.generate!
user = User.generate!
User.add_to_project(user, project, Role.find_by_name('Developer'))
field.user_role = [Role.find_by_name('Manager').id]
field.save!
issue = Issue.new(:project_id => project.id, :tracker_id => 1, :custom_field_values => {field.id => user.id})
assert_not_include [user.name, user.id.to_s], field.possible_custom_value_options(issue.custom_value_for(field))
assert_equal false, issue.valid?
assert_include "Foo #{::I18n.t('activerecord.errors.messages.inclusion')}", issue.errors.full_messages.first
end
def test_possible_values_options_should_return_project_members
field = IssueCustomField.new(:field_format => 'user')
project = Project.find(1)

View File

@ -49,6 +49,20 @@ class Redmine::VersionFieldFormatTest < ActionView::TestCase
assert issue.valid?
end
def test_not_existing_values_should_be_invalid
field = IssueCustomField.create!(:name => 'Foo', :field_format => 'version', :is_for_all => true, :trackers => Tracker.all)
project = Project.generate!
version = Version.generate!(:project => project, :status => 'closed')
field.version_status = ["open"]
field.save!
issue = Issue.new(:project_id => project.id, :tracker_id => 1, :custom_field_values => {field.id => version.id})
assert_not_include [version.name, version.id.to_s], field.possible_custom_value_options(issue.custom_value_for(field))
assert_equal false, issue.valid?
assert_include "Foo #{::I18n.t('activerecord.errors.messages.inclusion')}", issue.errors.full_messages.first
end
def test_possible_values_options_should_return_project_versions
field = IssueCustomField.new(:field_format => 'version')
project = Project.find(1)