meineerde/redmine
1
0
Fork 0
mirror of https://github.com/meineerde/redmine.git synced 2025-12-21 07:51:12 +00:00
Code Issues Releases Wiki Activity

shorten long line of IssuesControllerTest

Browse Source 
git-svn-id: http://svn.redmine.org/redmine/trunk@20674 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Toshi MARUYAMA 2020-12-19 17:32:34 +00:00
parent 15e78eb472
commit 4148f9c743
1 changed files with 48 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

68
test/functional/issues_controller_test.rb
View File

@ -3950,7 +3950,9 @@ class IssuesControllerTest < Redmine::ControllerTest
end end
def test_post_create_with_multi_user_custom_field def test_post_create_with_multi_user_custom_field
field = IssueCustomField.create!(:name => 'Multi user', :field_format => 'user', :multiple => true, field =
IssueCustomField.create!(:name => 'Multi user', :field_format => 'user',
:multiple => true,
:tracker_ids => [1], :is_for_all => true) :tracker_ids => [1], :is_for_all => true)
@request.session[:user_id] = 2 @request.session[:user_id] = 2
assert_difference 'Issue.count' do assert_difference 'Issue.count' do
@ -3998,11 +4000,15 @@ class IssuesControllerTest < Redmine::ControllerTest
end end
def test_create_should_validate_required_fields def test_create_should_validate_required_fields
cf1 = IssueCustomField.create!(:name => 'Foo', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2]) cf1 = IssueCustomField.create!(:name => 'Foo', :field_format => 'string',
cf2 = IssueCustomField.create!(:name => 'Bar', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2]) :is_for_all => true, :tracker_ids => [1, 2])
cf2 = IssueCustomField.create!(:name => 'Bar', :field_format => 'string',
:is_for_all => true, :tracker_ids => [1, 2])
WorkflowPermission.delete_all WorkflowPermission.delete_all
WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1, :field_name => 'due_date', :rule => 'required') WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1,
WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1, :field_name => cf2.id.to_s, :rule => 'required') :field_name => 'due_date', :rule => 'required')
WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1,
:field_name => cf2.id.to_s, :rule => 'required')
@request.session[:user_id] = 2 @request.session[:user_id] = 2
assert_no_difference 'Issue.count' do assert_no_difference 'Issue.count' do
post( post(
@ -4028,11 +4034,17 @@ class IssuesControllerTest < Redmine::ControllerTest
end end
def test_create_should_validate_required_list_fields def test_create_should_validate_required_list_fields
cf1 = IssueCustomField.create!(:name => 'Foo', :field_format => 'list', :is_for_all => true, :tracker_ids => [1, 2], :multiple => false, :possible_values => ['a', 'b']) cf1 = IssueCustomField.create!(:name => 'Foo', :field_format => 'list',
cf2 = IssueCustomField.create!(:name => 'Bar', :field_format => 'list', :is_for_all => true, :tracker_ids => [1, 2], :multiple => true, :possible_values => ['a', 'b']) :is_for_all => true, :tracker_ids => [1, 2],
:multiple => false, :possible_values => ['a', 'b'])
cf2 = IssueCustomField.create!(:name => 'Bar', :field_format => 'list',
:is_for_all => true, :tracker_ids => [1, 2],
:multiple => true, :possible_values => ['a', 'b'])
WorkflowPermission.delete_all WorkflowPermission.delete_all
WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1, :field_name => cf1.id.to_s, :rule => 'required') WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1,
WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1, :field_name => cf2.id.to_s, :rule => 'required') :field_name => cf1.id.to_s, :rule => 'required')
WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1,
:field_name => cf2.id.to_s, :rule => 'required')
@request.session[:user_id] = 2 @request.session[:user_id] = 2
assert_no_difference 'Issue.count' do assert_no_difference 'Issue.count' do
post( post(
@ -4058,11 +4070,15 @@ class IssuesControllerTest < Redmine::ControllerTest
end end
def test_create_should_ignore_readonly_fields def test_create_should_ignore_readonly_fields
cf1 = IssueCustomField.create!(:name => 'Foo', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2]) cf1 = IssueCustomField.create!(:name => 'Foo', :field_format => 'string',
cf2 = IssueCustomField.create!(:name => 'Bar', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2]) :is_for_all => true, :tracker_ids => [1, 2])
cf2 = IssueCustomField.create!(:name => 'Bar', :field_format => 'string',
:is_for_all => true, :tracker_ids => [1, 2])
WorkflowPermission.delete_all WorkflowPermission.delete_all
WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1, :field_name => 'due_date', :rule => 'readonly') WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1,
WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1, :field_name => cf2.id.to_s, :rule => 'readonly') :field_name => 'due_date', :rule => 'readonly')
WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1,
:field_name => cf2.id.to_s, :rule => 'readonly')
@request.session[:user_id] = 2 @request.session[:user_id] = 2
assert_difference 'Issue.count' do assert_difference 'Issue.count' do
post( post(
@ -4547,7 +4563,9 @@ class IssuesControllerTest < Redmine::ControllerTest
def test_post_create_with_failure_should_keep_saved_attachments def test_post_create_with_failure_should_keep_saved_attachments
set_tmp_attachments_directory set_tmp_attachments_directory
attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2) attachment =
Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"),
:author_id => 2)
@request.session[:user_id] = 2 @request.session[:user_id] = 2
assert_no_difference 'Issue.count' do assert_no_difference 'Issue.count' do
@ -4577,7 +4595,9 @@ class IssuesControllerTest < Redmine::ControllerTest
def test_post_create_should_attach_saved_attachments def test_post_create_should_attach_saved_attachments
set_tmp_attachments_directory set_tmp_attachments_directory
attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2) attachment =
Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"),
:author_id => 2)
@request.session[:user_id] = 2 @request.session[:user_id] = 2
assert_difference 'Issue.count' do assert_difference 'Issue.count' do
@ -4878,8 +4898,10 @@ class IssuesControllerTest < Redmine::ControllerTest
} }
) )
assert_select 'input[type=checkbox][name=?][checked=checked]', 'issue[watcher_user_ids][]', 2 assert_select 'input[type=checkbox][name=?][checked=checked]', 'issue[watcher_user_ids][]', 2
assert_select 'input[type=checkbox][name=?][checked=checked][value=?]', 'issue[watcher_user_ids][]', user.id.to_s assert_select 'input[type=checkbox][name=?][checked=checked][value=?]',
assert_select 'input[type=checkbox][name=?][checked=checked][value=?]', 'issue[watcher_user_ids][]', '10' 'issue[watcher_user_ids][]', user.id.to_s
assert_select 'input[type=checkbox][name=?][checked=checked][value=?]',
'issue[watcher_user_ids][]', '10'
assert_select 'input[type=hidden][name=?][value=?]', 'issue[watcher_user_ids][]', '', 1 assert_select 'input[type=hidden][name=?][value=?]', 'issue[watcher_user_ids][]', '', 1
end end
@ -4903,8 +4925,10 @@ class IssuesControllerTest < Redmine::ControllerTest
} }
) )
assert_select 'input[type=checkbox][name=?][checked=checked]', 'issue[watcher_user_ids][]', 1 assert_select 'input[type=checkbox][name=?][checked=checked]', 'issue[watcher_user_ids][]', 1
assert_select 'input[type=checkbox][name=?][checked=checked][value=?]', 'issue[watcher_user_ids][]', user.id.to_s assert_select 'input[type=checkbox][name=?][checked=checked][value=?]',
assert_select 'input[type=checkbox][name=?][checked=checked][value=?]', 'issue[watcher_user_ids][]', user2.id.to_s, 0 'issue[watcher_user_ids][]', user.id.to_s
assert_select 'input[type=checkbox][name=?][checked=checked][value=?]',
'issue[watcher_user_ids][]', user2.id.to_s, 0
assert_select 'input[type=hidden][name=?][value=?]', 'issue[watcher_user_ids][]', '', 1 assert_select 'input[type=hidden][name=?][value=?]', 'issue[watcher_user_ids][]', '', 1
end end
@ -5349,7 +5373,8 @@ class IssuesControllerTest < Redmine::ControllerTest
end end
def test_edit_should_hide_project_if_user_is_not_allowed_to_change_project def test_edit_should_hide_project_if_user_is_not_allowed_to_change_project
WorkflowPermission.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :field_name => 'project_id', :rule => 'readonly') WorkflowPermission.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1,
:field_name => 'project_id', :rule => 'readonly')
@request.session[:user_id] = 2 @request.session[:user_id] = 2
get(:edit, :params => {:id => 1}) get(:edit, :params => {:id => 1})
@ -5358,7 +5383,8 @@ class IssuesControllerTest < Redmine::ControllerTest
end end
def test_edit_should_not_hide_project_when_user_changes_the_project_even_if_project_is_readonly_on_target_project def test_edit_should_not_hide_project_when_user_changes_the_project_even_if_project_is_readonly_on_target_project
WorkflowPermission.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :field_name => 'project_id', :rule => 'readonly') WorkflowPermission.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1,
:field_name => 'project_id', :rule => 'readonly')
issue = Issue.generate!(:project_id => 2) issue = Issue.generate!(:project_id => 2)
@request.session[:user_id] = 2 @request.session[:user_id] = 2