meineerde/redmine
1
0
Fork 0
mirror of https://github.com/meineerde/redmine.git synced 2026-01-05 23:21:31 +00:00
Code Issues Releases Wiki Activity

shorten long line of IssuesHelper

Browse Source 
git-svn-id: http://svn.redmine.org/redmine/trunk@20523 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Toshi MARUYAMA 2020-11-30 15:48:44 +00:00
parent 5f1bce0032
commit 40c771b339
1 changed files with 48 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
app/helpers/issues_helper.rb
View File

@ -623,13 +623,55 @@ module IssuesHelper
if @journals.present?
journals_without_notes = @journals.select{|value| value.notes.blank?}
journals_with_notes = @journals.reject{|value| value.notes.blank?}
tabs << {:name => 'history', :label => :label_history, :onclick => 'showIssueHistory("history", this.href)', :partial => 'issues/tabs/history', :locals => {:issue => @issue, :journals => @journals}}
tabs << {:name => 'notes', :label => :label_issue_history_notes, :onclick => 'showIssueHistory("notes", this.href)'} if journals_with_notes.any?
tabs << {:name => 'properties', :label => :label_issue_history_properties, :onclick => 'showIssueHistory("properties", this.href)'} if journals_without_notes.any?
tabs <<
{
:name => 'history',
:label => :label_history,
:onclick => 'showIssueHistory("history", this.href)',
:partial => 'issues/tabs/history',
:locals => {:issue => @issue, :journals => @journals}
}
if journals_with_notes.any?
tabs <<
{
:name => 'notes',
:label => :label_issue_history_notes,
:onclick => 'showIssueHistory("notes", this.href)'
}
end
if journals_without_notes.any?
tabs <<
{
:name => 'properties',
:label => :label_issue_history_properties,
:onclick => 'showIssueHistory("properties", this.href)'
}
end
end
if User.current.allowed_to?(:view_time_entries, @project) && @issue.spent_hours > 0
tabs <<
{
:name => 'time_entries',
:label => :label_time_entry_plural,
:remote => true,
:onclick =>
"getRemoteTab('time_entries', " \
"'#{tab_issue_path(@issue, :name => 'time_entries')}', " \
"'#{issue_path(@issue, :tab => 'time_entries')}')"
}
end
if @has_changesets
tabs <<
{
:name => 'changesets',
:label => :label_associated_revisions,
:remote => true,
:onclick =>
"getRemoteTab('changesets', " \
"'#{tab_issue_path(@issue, :name => 'changesets')}', " \
"'#{issue_path(@issue, :tab => 'changesets')}')"
}
end
tabs << {:name => 'time_entries', :label => :label_time_entry_plural, :remote => true, :onclick => "getRemoteTab('time_entries', '#{tab_issue_path(@issue, :name => 'time_entries')}', '#{issue_path(@issue, :tab => 'time_entries')}')"} if User.current.allowed_to?(:view_time_entries, @project) && @issue.spent_hours > 0
tabs << {:name => 'changesets', :label => :label_associated_revisions, :remote => true, :onclick => "getRemoteTab('changesets', '#{tab_issue_path(@issue, :name => 'changesets')}', '#{issue_path(@issue, :tab => 'changesets')}')"} if @has_changesets
tabs
end
@ -648,5 +690,4 @@ module IssuesHelper
user_default_tab
end
end
end