meineerde/redmine
1
0
Fork 0
mirror of https://github.com/meineerde/redmine.git synced 2026-02-06 09:03:25 +00:00
Code Issues Releases Wiki Activity

Add support for PUT API to journals (#10171).

Browse Source 
Patch by Mizuki ISHIKAWA .


git-svn-id: https://svn.redmine.org/redmine/trunk@21496 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Go MAEDA 2022-03-23 14:26:47 +00:00
parent 30d91c8503
commit 32abb15847
2 changed files with 97 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/controllers/journals_controller.rb
View File

@ -23,6 +23,7 @@ class JournalsController < ApplicationController
before_action :find_optional_project, :only => [:index]
before_action :authorize, :only => [:new, :edit, :update, :diff]
accept_atom_auth :index
accept_api_auth :update
menu_item :issues
helper :issues
@ -97,6 +98,7 @@ class JournalsController < ApplicationController
respond_to do |format|
format.html {redirect_to issue_path(@journal.journalized)}
format.js
format.api { render_api_ok }
end
end

95
test/integration/api_test/journals_test.rb Normal file
View File

@ -0,0 +1,95 @@
# frozen_string_literal: true
# Redmine - project management software
# Copyright (C) 2006-2022 Jean-Philippe Lang
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
require File.expand_path('../../../test_helper', __FILE__)
class Redmine::ApiTest::JournalTest < Redmine::ApiTest::Base
fixtures :projects, :issues, :issue_statuses, :journals, :journal_details,
:issue_relations, :workflows,
:users, :members, :member_roles, :roles, :enabled_modules,
:groups_users, :email_addresses,
:enumerations,
:projects_trackers, :trackers, :custom_fields
test "PUT /journals/:id.xml with valid parameters should update the journal notes" do
put(
'/journals/1.xml',
params: {
journal: { notes: 'changed notes' }
},
headers: credentials('admin')
)
assert_response :no_content
assert_equal '', @response.body
journal = Journal.find(1)
assert_equal 'changed notes', journal.notes
end
test "PUT /journals/:id.json with valid parameters should update the journal notes" do
put(
'/journals/1.json',
params: {
journal: { notes: 'changed notes' }
},
headers: credentials('admin')
)
assert_response :no_content
assert_equal '', @response.body
journal = Journal.find(1)
assert_equal 'changed notes', journal.notes
end
test "PUT /journals/:id.xml without journal details should destroy journal" do
journal = Journal.find(5)
assert_equal [], journal.details
assert_difference('Journal.count', -1) do
put(
"/journals/#{journal.id}.xml",
params: {
journal: { notes: '' }
},
headers: credentials('admin')
)
end
assert_response :no_content
assert_equal '', @response.body
assert_nil Journal.find_by(id: 5)
end
test "PUT /journals/:id.json without journal details should destroy journal" do
journal = Journal.find(5)
assert_equal [], journal.details
assert_difference('Journal.count', -1) do
put(
"/journals/#{journal.id}.json",
params: {
journal: { notes: '' }
},
headers: credentials('admin')
)
end
assert_response :no_content
assert_equal '', @response.body
assert_nil Journal.find_by(id: 5)
end
end