meineerde/redmine
1
0
Fork 0
mirror of https://github.com/meineerde/redmine.git synced 2026-02-06 09:03:25 +00:00
Code Issues Releases Wiki Activity

Open Help in a separate tab (#1069).

Browse Source 
Contributed by Vijay Kiran.


git-svn-id: https://svn.redmine.org/redmine/trunk@21737 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Go MAEDA 2022-07-22 01:33:38 +00:00
parent 04e5ae033b
commit 3164895f69
3 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/views/layouts/base.html.erb
View File

@ -115,7 +115,7 @@
</div>
</div>
<div id="footer">
Powered by <%= link_to Redmine::Info.app_name, Redmine::Info.url %> &copy; 2006-2022 Jean-Philippe Lang
Powered by <%= link_to Redmine::Info.app_name, Redmine::Info.url, :target => '_blank', :rel => 'noopener' %> &copy; 2006-2022 Jean-Philippe Lang
</div>
<div id="ajax-indicator" style="display:none;"><span><%= l(:label_loading) %></span></div>

2
lib/redmine/preparation.rb
View File

@ -169,7 +169,7 @@ module Redmine
:caption => :label_project_plural
menu.push :administration, {:controller => 'admin', :action => 'index'},
:if => Proc.new {User.current.admin?}, :last => true
menu.push :help, Info.help_url, :last => true
menu.push :help, Info.help_url, :html => {:target => '_blank', :rel => 'noopener'}, :last => true
end
MenuManager.map :account_menu do |menu|

7
test/integration/layout_test.rb
View File

@ -127,4 +127,11 @@ class LayoutTest < Redmine::IntegrationTest
get '/projects/ecookbook'
assert_select 'div#quick-search form[action="/projects/ecookbook/search"]'
end
def test_help_and_powered_by_redmine_link_should_open_separate_tab
get '/'
assert_select '#top-menu a.help[target="_blank"][rel="noopener"]'
# "Powered by Redmine" link
assert_select '#footer a[target="_blank"][rel="noopener"]'
end
end