From 2ffe3fa547767d312158f7dee69dcee3bc9460d8 Mon Sep 17 00:00:00 2001 From: Go MAEDA Date: Mon, 20 Jan 2025 08:36:22 +0000 Subject: [PATCH] Optimize `Version#wiki_page` method (#42121). Avoid unnecessary evaluation of `project.wiki` when `wiki_page_title` is blank, reducing redundant SQL queries. Patch by Go MAEDA (user:maeda). git-svn-id: https://svn.redmine.org/redmine/trunk@23450 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- app/models/version.rb | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/app/models/version.rb b/app/models/version.rb index b6137d352..51c7c0417 100644 --- a/app/models/version.rb +++ b/app/models/version.rb @@ -312,10 +312,7 @@ class Version < ApplicationRecord end def wiki_page - if project.wiki && !wiki_page_title.blank? - @wiki_page ||= project.wiki.find_page(wiki_page_title) - end - @wiki_page + @wiki_page ||= project.wiki&.find_page(wiki_page_title) if wiki_page_title.present? end def to_s; name end