meineerde/redmine
1
0
Fork 0
mirror of https://github.com/meineerde/redmine.git synced 2025-12-30 20:29:37 +00:00
Code Issues Releases Wiki Activity

CSV related tests fail with Rails 5.2.4 (#32526, #32525).

Browse Source 
Patch by Go MAEDA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19344 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Go MAEDA 2019-12-08 00:10:43 +00:00
parent e675eaedab
commit 2de3dfeae5
5 changed files with 22 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
test/functional/issues_controller_test.rb
View File

@ -781,7 +781,7 @@ class IssuesControllerTest < Redmine::ControllerTest
get(:index, :params => {:format => 'csv'})
assert_response :success
assert_equal 'text/csv', @response.content_type
assert_equal 'text/csv', @response.media_type
assert response.body.starts_with?("#,")
lines = response.body.chomp.split("\n")
# default columns + id and project
@ -797,7 +797,7 @@ class IssuesControllerTest < Redmine::ControllerTest
}
)
assert_response :success
assert_equal 'text/csv', @response.content_type
assert_equal 'text/csv', @response.media_type
end
def test_index_csv_without_any_filters
@ -832,7 +832,7 @@ class IssuesControllerTest < Redmine::ControllerTest
)
assert_response :success
end
assert_equal 'text/csv', response.content_type
assert_equal 'text/csv', response.media_type
headers = response.body.chomp.split("\n").first.split(',')
assert_include 'Description', headers
assert_include 'test_index_csv_with_description', response.body
@ -860,7 +860,7 @@ class IssuesControllerTest < Redmine::ControllerTest
}
)
assert_response :success
assert_equal 'text/csv', @response.content_type
assert_equal 'text/csv', @response.media_type
lines = @response.body.chomp.split("\n")
assert_include "#{issue.id},#{issue.subject},7.33", lines
end
@ -875,7 +875,7 @@ class IssuesControllerTest < Redmine::ControllerTest
)
assert_response :success
assert_equal 'text/csv', @response.content_type
assert_equal 'text/csv', @response.media_type
assert_match /\A#,/, response.body
lines = response.body.chomp.split("\n")
assert_equal IssueQuery.new.available_inline_columns.size, lines[0].split(',').size
@ -973,7 +973,7 @@ class IssuesControllerTest < Redmine::ControllerTest
:format => 'csv'
}
)
assert_equal 'text/csv', @response.content_type
assert_equal 'text/csv', @response.media_type
lines = @response.body.chomp.split("\n")
header = lines[0]
status = (+"\xaa\xac\xbaA").force_encoding('Big5')
@ -996,7 +996,7 @@ class IssuesControllerTest < Redmine::ControllerTest
:set_filter => 1
}
)
assert_equal 'text/csv', @response.content_type
assert_equal 'text/csv', @response.media_type
lines = @response.body.chomp.split("\n")
header = lines[0]
issue_line = lines.find {|l| l =~ /^#{issue.id},/}
@ -1022,7 +1022,7 @@ class IssuesControllerTest < Redmine::ControllerTest
:set_filter => 1
}
)
assert_equal 'text/csv', @response.content_type
assert_equal 'text/csv', @response.media_type
lines = @response.body.chomp.split("\n")
assert_include "#{issue.id},1234.50,#{str1}", lines
end
@ -1042,7 +1042,7 @@ class IssuesControllerTest < Redmine::ControllerTest
:set_filter => 1
}
)
assert_equal 'text/csv', @response.content_type
assert_equal 'text/csv', @response.media_type
lines = @response.body.chomp.split("\n")
assert_include "#{issue.id};1234,50;#{str1}", lines
end
@ -1597,7 +1597,7 @@ class IssuesControllerTest < Redmine::ControllerTest
}
)
assert_response :success
assert_equal 'text/csv', response.content_type
assert_equal 'text/csv', response.media_type
lines = response.body.chomp.split("\n")
assert_include '1,"Related to #7, Related to #8, Blocks #11"', lines
assert_include '2,Blocked by #12', lines

2
test/functional/projects_controller_test.rb
View File

@ -203,7 +203,7 @@ class ProjectsControllerTest < Redmine::ControllerTest
with_settings :date_format => '%m/%d/%Y' do
get :index, :params => {:format => 'csv'}
assert_response :success
assert_equal 'text/csv', response.content_type
assert_equal 'text/csv', response.media_type
end
end

4
test/functional/timelog_controller_test.rb
View File

@ -1383,7 +1383,7 @@ class TimelogControllerTest < Redmine::ControllerTest
with_settings :date_format => '%m/%d/%Y' do
get :index, :params => {:format => 'csv'}
assert_response :success
assert_equal 'text/csv', response.content_type
assert_equal 'text/csv', response.media_type
end
end
@ -1391,7 +1391,7 @@ class TimelogControllerTest < Redmine::ControllerTest
with_settings :date_format => '%m/%d/%Y' do
get :index, :params => {:project_id => 1, :format => 'csv'}
assert_response :success
assert_equal 'text/csv', response.content_type
assert_equal 'text/csv', response.media_type
end
end

10
test/functional/timelog_report_test.rb
View File

@ -233,7 +233,7 @@ class TimelogReportTest < Redmine::ControllerTest
:format => "csv"
}
assert_response :success
assert_equal 'text/csv', @response.content_type
assert_equal 'text/csv', @response.media_type
lines = @response.body.chomp.split("\n")
# Headers
assert_equal 'Project,User,Activity,2007-3,2007-4,Total time', lines.first
@ -251,7 +251,7 @@ class TimelogReportTest < Redmine::ControllerTest
:format => "csv"
}
assert_response :success
assert_equal 'text/csv', @response.content_type
assert_equal 'text/csv', @response.media_type
lines = @response.body.chomp.split("\n")
# Headers
assert_equal 'Project,User,Overtime,2007-3,2007-4,Total time', lines.first
@ -289,7 +289,7 @@ class TimelogReportTest < Redmine::ControllerTest
}
end
assert_response :success
assert_equal 'text/csv', @response.content_type
assert_equal 'text/csv', @response.media_type
lines = @response.body.chomp.split("\n")
# Headers
s1 = (+"\xa5\xce\xa4\xe1,2011-11-11,\xa4u\xae\xc9\xc1`\xadp").force_encoding('Big5')
@ -334,7 +334,7 @@ class TimelogReportTest < Redmine::ControllerTest
}
end
assert_response :success
assert_equal 'text/csv', @response.content_type
assert_equal 'text/csv', @response.media_type
lines = @response.body.chomp.split("\n")
# Headers
s1 = (+"\xa5\xce\xa4\xe1,2011-11-11,\xa4u\xae\xc9\xc1`\xadp").force_encoding('Big5')
@ -369,7 +369,7 @@ class TimelogReportTest < Redmine::ControllerTest
:format => "csv"
}
assert_response :success
assert_equal 'text/csv', @response.content_type
assert_equal 'text/csv', @response.media_type
lines = @response.body.chomp.split("\n")
# Headers
s1 = (+"Utilisateur;2011-11-11;Temps total").force_encoding('ISO-8859-1')

8
test/functional/users_controller_test.rb
View File

@ -74,7 +74,7 @@ class UsersControllerTest < Redmine::ControllerTest
assert_equal User.logged.status(1).count, response.body.chomp.split("\n").size - 1
assert_include 'active', response.body
assert_not_include 'locked', response.body
assert_equal 'text/csv', @response.content_type
assert_equal 'text/csv', @response.media_type
end
end
@ -86,7 +86,7 @@ class UsersControllerTest < Redmine::ControllerTest
assert_equal User.logged.status(3).count, response.body.chomp.split("\n").size - 1
assert_include 'locked', response.body
assert_not_include 'active', response.body
assert_equal 'text/csv', @response.content_type
assert_equal 'text/csv', @response.media_type
end
end
@ -96,7 +96,7 @@ class UsersControllerTest < Redmine::ControllerTest
assert_equal User.logged.like('John').count, response.body.chomp.split("\n").size - 1
assert_include 'John', response.body
assert_equal 'text/csv', @response.content_type
assert_equal 'text/csv', @response.media_type
end
def test_index_csv_with_group_filter
@ -104,7 +104,7 @@ class UsersControllerTest < Redmine::ControllerTest
assert_response :success
assert_equal Group.find(10).users.count, response.body.chomp.split("\n").size - 1
assert_equal 'text/csv', @response.content_type
assert_equal 'text/csv', @response.media_type
end
def test_show