meineerde/redmine
1
0
Fork 0
mirror of https://github.com/meineerde/redmine.git synced 2025-12-19 15:01:14 +00:00
Code Issues Releases Wiki Activity

Code cleanup: RuboCop: Fix Style/UnneededCondition in app/models/setting.rb

Browse Source 
git-svn-id: http://svn.redmine.org/redmine/trunk@18397 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Go MAEDA 2019-08-26 07:16:55 +00:00
parent 47dd2083f7
commit 26774d09e9
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.rubocop_todo.yml
View File

@ -1830,7 +1830,6 @@ Style/UnneededCondition:
- 'app/controllers/messages_controller.rb' - 'app/controllers/messages_controller.rb'
- 'app/controllers/previews_controller.rb' - 'app/controllers/previews_controller.rb'
- 'app/models/issue.rb' - 'app/models/issue.rb'
- 'app/models/setting.rb'
# Cop supports --auto-correct. # Cop supports --auto-correct.
Style/UnneededInterpolation: Style/UnneededInterpolation:

5
app/models/setting.rb
View File

@ -107,13 +107,12 @@ class Setting < ActiveRecord::Base
# Returns the value of the setting named name # Returns the value of the setting named name
def self.[](name) def self.[](name)
v = @cached_settings[name] @cached_settings[name] ||= find_or_default(name).value
v ? v : (@cached_settings[name] = find_or_default(name).value)
end end
def self.[]=(name, v) def self.[]=(name, v)
setting = find_or_default(name) setting = find_or_default(name)
setting.value = (v ? v : "") setting.value = v || ''
@cached_settings[name] = nil @cached_settings[name] = nil
setting.save setting.save
setting.value setting.value