meineerde/redmine
1
0
Fork 0
mirror of https://github.com/meineerde/redmine.git synced 2026-02-05 08:33:25 +00:00
Code Issues Releases Wiki Activity

Use MIME type instead of the is_pdf flag to detect PDFs when generating thumbnails (#43451).

Browse Source 
Patch by Go MAEDA (user:maeda).



git-svn-id: https://svn.redmine.org/redmine/trunk@24266 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Marius Balteanu 2026-01-05 08:30:07 +00:00
parent a2069c2982
commit 23a93e0e06
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
app/models/attachment.rb
View File

@ -246,6 +246,7 @@ class Attachment < ApplicationRecord
target = thumbnail_path(size)
begin
# TODO: Stop passing the deprecated is_pdf flag in Redmine 7.0
Redmine::Thumbnail.generate(self.diskfile, target, size, is_pdf?)
rescue => e
if logger

8
lib/redmine/thumbnail.rb
View File

@ -33,21 +33,21 @@ module Redmine
ALLOWED_TYPES = %w(image/bmp image/gif image/jpeg image/png image/webp application/pdf)
# Generates a thumbnail for the source image to target
def self.generate(source, target, size, is_pdf = false)
# TODO: Remove the deprecated _is_pdf parameter in Redmine 7.0
def self.generate(source, target, size, _is_pdf = nil)
return nil unless convert_available?
return nil if is_pdf && !gs_available?
unless File.exist?(target)
# Make sure we only invoke Imagemagick if the file type is allowed
mime_type = File.open(source) {|f| Marcel::MimeType.for(f)}
return nil unless ALLOWED_TYPES.include? mime_type
return nil if is_pdf && mime_type != "application/pdf"
return nil if mime_type == 'application/pdf' && !gs_available?
directory = File.dirname(target)
FileUtils.mkdir_p directory
size_option = "#{size}x#{size}>"
if is_pdf
if mime_type == 'application/pdf'
cmd = "#{shell_quote CONVERT_BIN} #{shell_quote "#{source}[0]"} -thumbnail #{shell_quote size_option} #{shell_quote "png:#{target}"}"
else
cmd = "#{shell_quote CONVERT_BIN} #{shell_quote source} -auto-orient -thumbnail #{shell_quote size_option} #{shell_quote target}"