From 1c0b6075ee003b87190671816b1f06b227f2d9d5 Mon Sep 17 00:00:00 2001 From: Toshi MARUYAMA Date: Mon, 7 Oct 2019 11:45:11 +0000 Subject: [PATCH] use "attr_writer" instead of "attr_accessor" for QueryColumn#sortable QueryColumn#sortable is already defined in this class. git-svn-id: http://svn.redmine.org/redmine/trunk@18616 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- .rubocop_todo.yml | 1 - app/models/query.rb | 3 ++- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index cbaa842b8..2392983c2 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -495,7 +495,6 @@ Lint/DeprecatedClassMethods: Lint/DuplicateMethods: Exclude: - - 'app/models/query.rb' - 'app/models/wiki_page.rb' Lint/EmptyWhen: diff --git a/app/models/query.rb b/app/models/query.rb index bd2b0c5c1..3b37a8dd0 100644 --- a/app/models/query.rb +++ b/app/models/query.rb @@ -20,7 +20,8 @@ require 'redmine/sort_criteria' class QueryColumn - attr_accessor :name, :sortable, :groupable, :totalable, :default_order + attr_accessor :name, :groupable, :totalable, :default_order + attr_writer :sortable include Redmine::I18n def initialize(name, options={})