meineerde/redmine
1
0
Fork 0
mirror of https://github.com/meineerde/redmine.git synced 2026-01-08 16:41:31 +00:00
Code Issues Releases Wiki Activity

Export to PDF fails when subject of parent task is included in issue list (#33103).

Browse Source 
Patch by Marius BALTEANU and Yuichi HARADA.


git-svn-id: http://svn.redmine.org/redmine/trunk@19611 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Go MAEDA 2020-03-24 12:16:06 +00:00
parent 64abc4bd85
commit 1473996f92
2 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/redmine/export/pdf/issues_pdf_helper.rb
View File

@ -379,7 +379,7 @@ module Redmine
cv = issue.visible_custom_field_values.detect {|v| v.custom_field_id == column.custom_field.id}
show_value(cv, false)
else
value = issue.send(column.name)
value = column.value_object(issue)
case column.name
when :subject
value = " " * level + value

11
test/unit/lib/redmine/export/pdf/issues_pdf_test.rb
View File

@ -36,4 +36,15 @@ class IssuesPdfHelperTest < ActiveSupport::TestCase
results = fetch_row_values(issue, query, 0)
assert_equal ["2", "Add ingredients categories", "4.34"], results
end
def test_fetch_row_values_should_be_able_to_handle_parent_issue_subject
query = IssueQuery.new(:project => Project.find(1), :name => '_')
query.column_names = [:subject, 'parent.subject']
issue = Issue.find(2)
issue.parent = Issue.find(1)
issue.save!
results = fetch_row_values(issue, query, 0)
assert_equal ['2', 'Add ingredients categories', 'Cannot print recipes'], results
end
end