meineerde/redmine
1
0
Fork 0
mirror of https://github.com/meineerde/redmine.git synced 2026-01-31 11:37:14 +00:00
Code Issues Releases Wiki Activity

Support localized decimal separators for float values in PDF export (#22024).

Browse Source 
Patch by Go MAEDA (@maeda).


git-svn-id: https://svn.redmine.org/redmine/trunk@22594 e93f8b46-1217-0410-a6f0-8f06a7374b81
This commit is contained in:
Go MAEDA 2024-01-04 07:04:00 +00:00
parent f7d2f9f00b
commit 0be4013919
2 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/redmine/export/pdf/issues_pdf_helper.rb
View File

@ -21,6 +21,8 @@ module Redmine
module Export
module PDF
module IssuesPdfHelper
include ActionView::Helpers::NumberHelper
# Returns a PDF string of a single issue
def issue_to_pdf(issue, assoc={})
pdf = ITCPDF.new(current_language)
@ -406,7 +408,7 @@ module Redmine
elsif value.is_a?(Time)
format_time(value)
elsif value.is_a?(Float)
sprintf "%.2f", value
number_with_delimiter(sprintf('%.2f', value), delimiter: nil)
else
value
end

9
test/unit/lib/redmine/export/pdf/issues_pdf_test.rb
View File

@ -33,8 +33,13 @@ class IssuesPdfHelperTest < ActiveSupport::TestCase
time_entry = TimeEntry.create!(:spent_on => Date.today, :hours => 4.3432, :user => user, :author => user,
:project_id => 1, :issue => issue, :activity => TimeEntryActivity.first)
results = fetch_row_values(issue, query, 0)
assert_equal ["2", "Add ingredients categories", "4.34"], results
to_test = {'en' => '4.34', 'de' => '4,34'}
to_test.each do |locale, expected|
with_locale locale do
results = fetch_row_values(issue, query, 0)
assert_equal ['2', 'Add ingredients categories', expected], results
end
end
end
def test_fetch_row_values_should_be_able_to_handle_parent_issue_subject