From 0b138f1c4e2466c6371010697572f8155cd0e3da Mon Sep 17 00:00:00 2001 From: Toshi MARUYAMA Date: Sat, 4 Jul 2020 12:14:11 +0000 Subject: [PATCH] avoid multi-line ternary operators in app/controllers/workflows_controller.rb git-svn-id: http://svn.redmine.org/redmine/trunk@19854 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- app/controllers/workflows_controller.rb | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/app/controllers/workflows_controller.rb b/app/controllers/workflows_controller.rb index 333a38b66..d53d007f8 100644 --- a/app/controllers/workflows_controller.rb +++ b/app/controllers/workflows_controller.rb @@ -92,10 +92,18 @@ class WorkflowsController < ApplicationController else @source_role = Role.find_by_id(params[:source_role_id].to_i) end - @target_trackers = params[:target_tracker_ids].blank? ? - nil : Tracker.where(:id => params[:target_tracker_ids]).to_a - @target_roles = params[:target_role_ids].blank? ? - nil : Role.where(:id => params[:target_role_ids]).to_a + @target_trackers = + if params[:target_tracker_ids].blank? + nil + else + Tracker.where(:id => params[:target_tracker_ids]).to_a + end + @target_roles = + if params[:target_role_ids].blank? + nil + else + Role.where(:id => params[:target_role_ids]).to_a + end if request.post? if params[:source_tracker_id].blank? || params[:source_role_id].blank? || (@source_tracker.nil? && @source_role.nil?)