Fix RuboCop offense Lint/RedundantStringCoercion, one of the offenses enabled in rubocop-rails-omakase (#39887).

git-svn-id: https://svn.redmine.org/redmine/trunk@22955 e93f8b46-1217-0410-a6f0-8f06a7374b81

.rubocop_todo.yml

@@ -231,13 +231,6 @@ Lint/ParenthesesAsGroupedExpression:
     - 'test/unit/attachment_test.rb'
     - 'test/unit/lib/redmine/export/pdf_test.rb'
 
-# This cop supports safe autocorrection (--autocorrect).
-Lint/RedundantStringCoercion:
-  Exclude:
-    - 'lib/redmine/export/pdf/issues_pdf_helper.rb'
-    - 'test/functional/repositories_filesystem_controller_test.rb'
-    - 'test/functional/repositories_git_controller_test.rb'
-
 # This cop supports safe autocorrection (--autocorrect).
 Lint/SendWithMixinArgument:
   Exclude:

lib/redmine/export/pdf/issues_pdf_helper.rb

@@ -38,7 +38,7 @@ module Redmine
           i = 1
           issue.ancestors.visible.each do |ancestor|
             pdf.set_x(base_x + i)
-            buf = "#{ancestor.tracker} # #{ancestor.id} (#{ancestor.status.to_s}): #{ancestor.subject}"
+            buf = "#{ancestor.tracker} # #{ancestor.id} (#{ancestor.status}): #{ancestor.subject}"
             pdf.RDMMultiCell(190 - i, 5, buf)
             i += 1 if i < 35
           end

test/functional/repositories_filesystem_controller_test.rb

@@ -126,7 +126,7 @@ class RepositoriesFilesystemControllerTest < Redmine::RepositoryControllerTest
         if @ruby19_non_utf8_pass
           puts "TODO: show repository file contents test fails " \
                "when Encoding.default_external is not UTF-8. " \
-               "Current value is '#{Encoding.default_external.to_s}'"
+               "Current value is '#{Encoding.default_external}'"
         else
           assert_select 'tr#L3 td.line-code', :text => /日本語/
         end

test/functional/repositories_git_controller_test.rb

@@ -832,6 +832,6 @@ class RepositoriesGitControllerTest < Redmine::RepositoryControllerTest
   def puts_pass_on_not_utf8
     puts "TODO: This test fails " +
          "when Encoding.default_external is not UTF-8. " +
-         "Current value is '#{Encoding.default_external.to_s}'"
+         "Current value is '#{Encoding.default_external}'"
   end
 end