1
0
mirror of https://github.com/meineerde/rackstash.git synced 2025-10-17 14:01:01 +00:00

156 Commits

Author SHA1 Message Date
54c10a0576 Improve code formatting in specs for Rackstash::Flows 2017-05-09 22:21:19 +02:00
da8904f412 Add a thread-safe Rackstash::Flows#each method 2017-05-09 22:20:23 +02:00
3a74701dd9 Add code documentation for Rackstash::Flows 2017-05-09 22:18:12 +02:00
335bbe0064 Test the correct alias-methods for Flows#to_ary and Flows#to_a 2017-05-06 23:49:51 +02:00
eb6cb29440 Return only present flows from Flows#to_ary 2017-05-06 23:49:05 +02:00
b2c1a1da0e Rename Target(List) to Flow(s)
Since a flow will significantly affect the representation of a log event
over its life before being persistet by the final adapter, the new term
better reflects what it is responsible for.

It also helps to avoid the dupliction of meaning between Sink, Target,
Adapter.
2017-05-06 14:47:40 +02:00
ec30779429 Remove unused variable in specs 2017-05-04 21:40:23 +02:00
5f68082810 Add Rackstash::TargetList to hold a list of defined log targets
The TargetList behaves mostly like an array which ensures that all its
elements are Targets.
2017-04-27 23:49:56 +02:00
3ccacfaab9 Move DEFAULT_OBJ_ID_STR_WIDTH to Rackstash module 2017-04-27 23:48:30 +02:00
a6c6fcc90b Protect the BufferStack with a Mutex 2017-04-27 22:05:40 +02:00
2b0de27956 Return nil on BufferStacl#flush_and_pop
The buffer should not be reused after a flush anyway. By not returning
it, we ensure that it does not leak outside.
2017-04-27 22:04:13 +02:00
4bbbf25ef8 Use a Concurrent::Array for storing messages in the Buffer
This ensures that we can still concurrently add messages without messing
with the internal Array.
2017-04-27 21:49:36 +02:00
e84d372c08 Bump Ruby versions for Travis CI 2017-04-19 00:11:06 +02:00
473618c479 Extract the SEVERITY_NAMES constant
This array lists the lowercase names of the supported severities which
can be set on the Logger.
2017-04-18 21:26:31 +02:00
7459a27a1c Explicitly name supported collection types during normalize
Since an AbstractCollection can in principal contain any raw value, we
want to make sure that we only handle known values. Others will probably
still be catched by the fallback converter calls at the bottom of
AbstractCollection#normalize.
2017-04-18 21:25:05 +02:00
0026cdb204 Format the message string in the Logger
Since the Message class now formats the passed message on initialization
anyways, there is no need anymore to retain the formatter there.
Instead, we can just format the message string in the Logger before
creating the Message instance.

This significantly simplifies the Message class and better encapsulates
the knowledge about the line formatter into the Logger class.
2017-04-18 21:25:05 +02:00
f3f6fba89b Format the passed message on Message initialization
Since we can not guarantee that a user-supplied formatter is side-effect
free, a delayed formatting might result in unexpected results. An
example of such a formatter is the one used by
ActiveSupport::TaggedLogging.
2017-04-13 17:42:28 +02:00
dc9d553509 Display native-size object IDs in AbstractCollection#inspect 2017-04-06 23:09:22 +02:00
d9c7a2ad33 Add Fields::Array#push as an alias to #<< 2017-04-06 23:09:22 +02:00
7e452b630a Create new fields, tags and message objects on Buffer#clear
This helps in ensuring thread-safety when flushing unbuffered Buffers.
Previously, it was possibly for client code to still hold references to
fields on a flushed and cleared buffer, potentially resulting in
unintended side-effects if the client code was not aware that the buffer
was cleared.

By creating ompletely new object instances, existing references only
point to data from before the clear. This ensures a clean cut.
2017-04-06 23:09:16 +02:00
0edcce37c7 Use yield instead of to_proc in Hash#merge
This is functionally equivalent. However, the previous behavior resulted
in the block being materialized as a proc which is quite expensive, both
during materialization as well as when calling it. By using
`block_given?`, we can avoid this materialization.
2017-03-28 20:05:23 +02:00
16cb49c3f1 Improve method documentation on Fields::Hash 2017-03-07 16:45:47 +01:00
bfa5e33c04 Add Fields::Hash#reverse_merge and reverse_merge! similar to the ActiveSupport methods on Hash 2017-03-07 16:45:47 +01:00
2070bf81a7 Move Fields::Hash#forbidden_key? into its correct alphabetical position 2017-03-07 14:52:12 +01:00
b2d2a89488 Make parameter documentation more exact 2017-02-18 22:40:36 +01:00
1eecb1bf3d Improve code style in the Gemfile 2017-02-18 22:39:36 +01:00
22d1cdb646 Add Rackstash::Fields::Hash#deep_merge! and deep_merge
These methods are useful convenience methods to add (nested) fields to a
hash while optionally retaining existing values. Usually, `#deep_merge!`
or `#set` will be the commonly used ways to set fields to a hash.
2017-02-18 22:36:21 +01:00
4a185096d6 Add Rackstash::Fields::Hash#key? predicate 2017-02-18 01:15:49 +01:00
e13efe5ed3 Add consistent hash method to Rackstash::Fields::AbstractCollection
This follows the rule that two objects which are eql? also have the same
hash value. It is also required to ensure that we can use collections in
sets, hashes and arrays where the hash-equality is checked for certain
operations.
2017-02-17 19:12:47 +01:00
95fdb38ea8 Test coverage in a special job on Travis-CI due to sub-par coverage results for JRuby 2017-02-16 23:42:49 +01:00
411465073f Check code coverage of tests using coveralls 2017-02-16 23:26:24 +01:00
0339d4bced Test Rackstssh::Fields::AbstractCollection#clone 2017-02-16 23:08:42 +01:00
494b64c63a Remove redundant private method Rackstash::Fields::Array#new
The method is already provided by the parent class AbstractCollection
2017-02-16 23:04:57 +01:00
6958b8f509 Add Rubocop config and resolve most style issues 2017-02-16 22:47:17 +01:00
f6453e0f47 Replace overwritten conversion methods with implicit method to retain expected method behavior 2017-02-16 21:55:30 +01:00
2cff0cb5fa Improve code formatting 2017-02-16 20:54:11 +01:00
b9a1b0c386 Clarify how the scope parameter works on field methods 2017-02-16 20:53:41 +01:00
057cf2c8f7 Add Rackstash::Fields::Array#merge and #merge! which work similar to the union operator 2017-02-16 20:50:38 +01:00
b14f7a95af Clarify that all field methods accepting values can also accept Proc 2017-02-16 20:38:25 +01:00
890b193234 Add basic array operations to Rackstash::Fields::Array 2017-02-16 01:14:20 +01:00
c401a29ab3 Allow to specify a custom scope in Rackstash::Fields::Array#concat 2017-02-16 00:41:40 +01:00
8232d139f4 Add specs for handling of nested procs inside arrays with fields 2017-02-16 00:39:08 +01:00
bd376af884 Use thread-safe raw objects for field hashes and arrays 2017-02-14 22:47:55 +01:00
3ec21e7646 Always resolve procs when setting them into fields 2017-02-13 23:37:02 +01:00
5fc679a63a Document additional public methods 2017-02-10 23:48:49 +01:00
ad038f4317 Add Rackstash::Fields::Array#<< to add a value at the end of the array 2017-02-10 23:22:41 +01:00
ebd2a19251 Test that Logger#add sets the current formatter on the message 2017-02-09 23:31:48 +01:00
68a2b57e28 Add Logger#<< to ad a raw unformatted message to the buffer
If the current Buffer is bufering, the message will just be added. Else,
it will be flushed to the sink directly.
2017-02-09 14:13:31 +01:00
031198cf14 Add Hash#set to set a field from a block if it doesn't exist yet
This allows to define default values for certain fields which can be
inserted just before a Buffer is flushed. They won;t overwrite prior
user-provided fields.

Through the use of a block, expensive calculations for a field could be
avoided if the field is not going to be inserted, e.g. because it exists
already or is forbidden from being set.
2017-02-09 00:15:18 +01:00
ea77a8ae26 Add bare-bones CHANGELOG 2017-02-08 00:03:24 +01:00