meineerde/rackstash
1
0
Fork 0
mirror of https://github.com/meineerde/rackstash.git synced 2025-12-19 15:01:12 +00:00
Code Issues Releases Activity

Test sane behavior when trying to set fields or tags causing exception in Rack::Middleware

Browse Source
This commit is contained in:
Holger Just 2018-01-30 12:05:42 +01:00
parent ce12e26bba
commit 58b58cfe4a
1 changed files with 48 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
spec/rackstash/rack/middleware_spec.rb
View File

@ -137,6 +137,22 @@ describe Rackstash::Rack::Middleware do
'method' => 'GET'
)
end
context 'on merge errors' do
it 'raises an error' do
args[:request_fields] = ->(_request){ raise 'Oh No!' }
expect { get('/stuff') }.to raise_error RuntimeError, 'Oh No!'
expect(log.last).to include(
'path' => '/stuff',
'method' => 'GET',
'status' => 500,
'error' => 'RuntimeError',
'error_message' => 'Oh No!',
'error_trace' => %r{\A#{__FILE__}:#{__LINE__ - 9}:in}
)
end
end
end
context 'with request_tags' do
@ -148,6 +164,22 @@ describe Rackstash::Rack::Middleware do
expect(log.last).to include('tags' => ['foo', 'STUFF'])
end
context 'on merge errors' do
it 'raises an error' do
args[:request_tags] = ->(_request){ raise 'Oh No!' }
expect { get('/stuff') }.to raise_error RuntimeError, 'Oh No!'
expect(log.last).to include(
'path' => '/stuff',
'method' => 'GET',
'status' => 500,
'error' => 'RuntimeError',
'error_message' => 'Oh No!',
'error_trace' => %r{\A#{__FILE__}:#{__LINE__ - 9}:in}
)
end
end
end
context 'with response fields' do
@ -172,6 +204,22 @@ describe Rackstash::Rack::Middleware do
expect(log.last).to include 'path' => '/stuff'
end
context 'on merge errors' do
it 'raises an error' do
args[:response_fields] = ->(_headers){ raise 'Oh No!' }
expect { get('/stuff') }.to raise_error RuntimeError, 'Oh No!'
expect(log.last).to include(
'path' => '/stuff',
'method' => 'GET',
'status' => 500,
'error' => 'RuntimeError',
'error_message' => 'Oh No!',
'error_trace' => %r{\A#{__FILE__}:#{__LINE__ - 9}:in}
)
end
end
end
context 'with response_tags' do