meineerde/rackstash
1
0
Fork 0
mirror of https://github.com/meineerde/rackstash.git synced 2025-10-17 14:01:01 +00:00
Code Issues Releases Activity

Use a Concurrent::CyclicBarrier instead of file locking for concurrent file adapter tests

Browse Source
This commit is contained in:
Holger Just 2019-09-17 20:00:10 +02:00
parent f304f04ded
commit 0907a85e81
1 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
spec/rackstash/adapter/file_spec.rb
View File

@ -307,14 +307,16 @@ RSpec.describe Rackstash::Adapter::File do
let(:lines_per_worker) { 50 }
let(:line_length) { 4096 }
let(:barrier) { Concurrent::CyclicBarrier.new(workers) }
def run_worker(worker_id)
filler = (worker_id + 65).chr
line = filler * line_length
adapter = described_class.new(logfile.path)
# Wait until the parent releases the exclusive lock
logfile.flock(File::LOCK_SH)
# Wait until all worker threads are ready to start
barrier.wait
lines_per_worker.times do
adapter.write(line)
@ -328,19 +330,12 @@ RSpec.describe Rackstash::Adapter::File do
# This test was adapted from
# http://www.notthewizard.com/2014/06/17/are-files-appends-really-atomic/
it 'writes atomic log lines' do
# First, create an exclusive lock on the logfile to ensure all workers
# start at about the same time
logfile.flock(File::LOCK_EX)
worker_threads = Array.new(workers) { |worker_id|
Thread.new do
run_worker worker_id
end
}
# Worker threads will only start writing once we have released the lock
logfile.flock(File::LOCK_UN)
worker_threads.each do |thread|
thread.join
end